27
Fri, Dec
0 New Articles

Type in the Data Type or You're Fired!

RPG
Typography
  • Smaller Small Medium Big Bigger
  • Default Helvetica Segoe Georgia Times

Believe it or not, there are actually programmers who advocate using the latest technologies yet continue to do one very amateurish thing. Can you guess what it is?

Let's start with what is often advocated by the leading-edge programmers: long field names and free-format. Both of these are good features to have in a programming language and should be used when people are comfortable using them or when a shop standard is in place that advocates either.

With RPG IV, using long variable names is nearly as easy as in any other programming language. Granted, we have our share of obscurities, but it is fairly benign to name a field something like COMPNAME, COMPANY_NAME, or even, CUSTOMER_COMPANY_NAME. Compare that with CMPNAM or CSTNAM used in pre-RPG IV days.

Regardless of whether using CUSTOMER_COMPANY_NAME as a specific variable name is a good idea, the fact is that in RPG IV it is considered a contemporary programming practice. The use of longer, more descriptive variable names in source code is preferred over the passé six-character variable names to which we were previously limited.

Of course, advocating free-format a la the /FREE specification in RPG IV is a common characteristic of those who also advocate long field names. After all, how do you fit those long field names into the traditional extended Factor 2 C-spec of an EVAL opcode and also include any other expression symbols?

I'm still not a fan of the /FREE specification; however, I no longer hate it as I once did. There are far too many other things to resent in RPG IV. For now, I view /FREE as most countries view their own atomic weapons stockpile: It is a powerful tool that I hope I never have to use.

Is That Packed or Zoned?

But herein lies the irony: Many RPG IV programmers who advocate /FREE and/or long variable names tend to avoid specifying data types on field declarations.

What's very interesting to me is that if they can type in CUSTOMER_COMPANY_NAME, why then can they not enter 3P0 if they mean packed or 3S0 if they mean zoned? Quick, what type of field is 3 0?

To be honest, I can't even tell you what type of field it is. Why? Because I don't care. If you want me to be able to read your code and make accurate changes, then put in the darn data type, you lazy coder.

Here are three examples of what happens when you do not use the data type in your code:

Input Specifications

     ICUSTREC       NS
     I                                  1    7 0CUSTNO        
     I                                  8   37  COMPNAME      

In this example, the CUSTNO field is defined as what? Zoned decimal. The COMPNAME field is character.

Data Structure Subfields

     D CUSTOMER        DS
     D  CUSTNO                        7  0
     D  COMPNAME                     30

In this example, the CUSTNO subfield is defined as zoned decimal, and the COMPNAME field is character.

Standalone "Work" Fields

     D CUSTNO          S              7  0
     D COMPNAME        S             30

Now, in this example, CUSTNO is defined as packed decimal, and COMPNAME is, of course, character.

If you were a good programmer, you would (A) not know this and (B) have written the code as follows:

     ICUSTREC       NS
     I                             S    1    7 0CUSTNO
     I                                  8   37  COMPNAME      

     D CUSTOMER        DS
     D  CUSTNO                        7S 0
     D  COMPNAME                     30

     D CUSTNO          S              7P 0
     D COMPNAME        S             30

Of course, you probably really meant that the field was packed or zoned in all situations. So perhaps the following would be more appropriate:

     ICUSTREC       NS
     I                             S    1    7 0CUSTNO
     I                                  8   37  COMPNAME      

     D CUSTOMER        DS
     D  CUSTNO                        7S 0
     D  COMPNAME                     30

     D CUSTNO          S              7S 0
     D COMPNAME        S             30

Actually, there's something missing from the above examples; the COMPNAME data type is blank. Let's fix that.

     ICUSTREC       NS
     I                             S    1    7 0CUSTNO
     I                             A    8   37  COMPNAME      

     D CUSTOMER        DS
     D  CUSTNO                        7S 0
     D  COMPNAME                     30A

     D CUSTNO          S              7P 0
     D COMPNAME        S             30A

Now this is how you should be writing code!

Regardless of the fact that numeric data structure subfields without a data type default to zoned decimal, while numeric standalone fields default to packed (number 18 on my list of dumb things IBM built into RPG IV), there is absolutely no reason for programmers to omit the data type from a field. Please excuse me if I'm being rude, but doing so really shows how lazy you are. And think about this: If I'm looking at your code and assume that a typeless numeric variable is packed, I could spend hours or even days looking in the wrong place for a bug.

So don't be lazy! Write good code!

Bob Cozzi is a programmer/consultant, writer/author, and software developer of the RPG xTools, a popular add-on subprocedure library for RPG IV. His book The Modern RPG Language has been the most widely used RPG programming book for nearly two decades. He, along with others, speaks at and runs the highly-popular RPG World conference for RPG programmers.

BLOG COMMENTS POWERED BY DISQUS

LATEST COMMENTS

Support MC Press Online

$

Book Reviews

Resource Center

  • SB Profound WC 5536 Have you been wondering about Node.js? Our free Node.js Webinar Series takes you from total beginner to creating a fully-functional IBM i Node.js business application. You can find Part 1 here. In Part 2 of our free Node.js Webinar Series, Brian May teaches you the different tooling options available for writing code, debugging, and using Git for version control. Brian will briefly discuss the different tools available, and demonstrate his preferred setup for Node development on IBM i or any platform. Attend this webinar to learn:

  • SB Profound WP 5539More than ever, there is a demand for IT to deliver innovation. Your IBM i has been an essential part of your business operations for years. However, your organization may struggle to maintain the current system and implement new projects. The thousands of customers we've worked with and surveyed state that expectations regarding the digital footprint and vision of the company are not aligned with the current IT environment.

  • SB HelpSystems ROBOT Generic IBM announced the E1080 servers using the latest Power10 processor in September 2021. The most powerful processor from IBM to date, Power10 is designed to handle the demands of doing business in today’s high-tech atmosphere, including running cloud applications, supporting big data, and managing AI workloads. But what does Power10 mean for your data center? In this recorded webinar, IBMers Dan Sundt and Dylan Boday join IBM Power Champion Tom Huntington for a discussion on why Power10 technology is the right strategic investment if you run IBM i, AIX, or Linux. In this action-packed hour, Tom will share trends from the IBM i and AIX user communities while Dan and Dylan dive into the tech specs for key hardware, including:

  • Magic MarkTRY the one package that solves all your document design and printing challenges on all your platforms. Produce bar code labels, electronic forms, ad hoc reports, and RFID tags – without programming! MarkMagic is the only document design and print solution that combines report writing, WYSIWYG label and forms design, and conditional printing in one integrated product. Make sure your data survives when catastrophe hits. Request your trial now!  Request Now.

  • SB HelpSystems ROBOT GenericForms of ransomware has been around for over 30 years, and with more and more organizations suffering attacks each year, it continues to endure. What has made ransomware such a durable threat and what is the best way to combat it? In order to prevent ransomware, organizations must first understand how it works.

  • SB HelpSystems ROBOT GenericIT security is a top priority for businesses around the world, but most IBM i pros don’t know where to begin—and most cybersecurity experts don’t know IBM i. In this session, Robin Tatam explores the business impact of lax IBM i security, the top vulnerabilities putting IBM i at risk, and the steps you can take to protect your organization. If you’re looking to avoid unexpected downtime or corrupted data, you don’t want to miss this session.

  • SB HelpSystems ROBOT GenericCan you trust all of your users all of the time? A typical end user receives 16 malicious emails each month, but only 17 percent of these phishing campaigns are reported to IT. Once an attack is underway, most organizations won’t discover the breach until six months later. A staggering amount of damage can occur in that time. Despite these risks, 93 percent of organizations are leaving their IBM i systems vulnerable to cybercrime. In this on-demand webinar, IBM i security experts Robin Tatam and Sandi Moore will reveal:

  • FORTRA Disaster protection is vital to every business. Yet, it often consists of patched together procedures that are prone to error. From automatic backups to data encryption to media management, Robot automates the routine (yet often complex) tasks of iSeries backup and recovery, saving you time and money and making the process safer and more reliable. Automate your backups with the Robot Backup and Recovery Solution. Key features include:

  • FORTRAManaging messages on your IBM i can be more than a full-time job if you have to do it manually. Messages need a response and resources must be monitored—often over multiple systems and across platforms. How can you be sure you won’t miss important system events? Automate your message center with the Robot Message Management Solution. Key features include:

  • FORTRAThe thought of printing, distributing, and storing iSeries reports manually may reduce you to tears. Paper and labor costs associated with report generation can spiral out of control. Mountains of paper threaten to swamp your files. Robot automates report bursting, distribution, bundling, and archiving, and offers secure, selective online report viewing. Manage your reports with the Robot Report Management Solution. Key features include:

  • FORTRAFor over 30 years, Robot has been a leader in systems management for IBM i. With batch job creation and scheduling at its core, the Robot Job Scheduling Solution reduces the opportunity for human error and helps you maintain service levels, automating even the biggest, most complex runbooks. Manage your job schedule with the Robot Job Scheduling Solution. Key features include:

  • LANSA Business users want new applications now. Market and regulatory pressures require faster application updates and delivery into production. Your IBM i developers may be approaching retirement, and you see no sure way to fill their positions with experienced developers. In addition, you may be caught between maintaining your existing applications and the uncertainty of moving to something new.

  • LANSAWhen it comes to creating your business applications, there are hundreds of coding platforms and programming languages to choose from. These options range from very complex traditional programming languages to Low-Code platforms where sometimes no traditional coding experience is needed. Download our whitepaper, The Power of Writing Code in a Low-Code Solution, and:

  • LANSASupply Chain is becoming increasingly complex and unpredictable. From raw materials for manufacturing to food supply chains, the journey from source to production to delivery to consumers is marred with inefficiencies, manual processes, shortages, recalls, counterfeits, and scandals. In this webinar, we discuss how:

  • The MC Resource Centers bring you the widest selection of white papers, trial software, and on-demand webcasts for you to choose from. >> Review the list of White Papers, Trial Software or On-Demand Webcast at the MC Press Resource Center. >> Add the items to yru Cart and complet he checkout process and submit

  • Profound Logic Have you been wondering about Node.js? Our free Node.js Webinar Series takes you from total beginner to creating a fully-functional IBM i Node.js business application.

  • SB Profound WC 5536Join us for this hour-long webcast that will explore:

  • Fortra IT managers hoping to find new IBM i talent are discovering that the pool of experienced RPG programmers and operators or administrators with intimate knowledge of the operating system and the applications that run on it is small. This begs the question: How will you manage the platform that supports such a big part of your business? This guide offers strategies and software suggestions to help you plan IT staffing and resources and smooth the transition after your AS/400 talent retires. Read on to learn: